alamb commented on code in PR #23448:
URL: https://github.com/apache/datafusion/pull/23448#discussion_r3561526199
##########
datafusion/common-runtime/src/join_set.rs:
##########
@@ -21,10 +21,13 @@ use std::task::{Context, Poll};
use tokio::runtime::Handle;
use tokio::task::{AbortHandle, Id, JoinError, LocalSet};
-/// A wrapper around Tokio's JoinSet that forwards all API calls while
optionally
+/// A wrapper around [Tokio's `JoinSet`] that forwards all API calls while
optionally
/// instrumenting spawned tasks and blocking closures with custom tracing
behavior.
-/// If no tracer is injected via `trace_utils::set_tracer`, tasks and closures
are executed
+/// If no tracer is injected via [`set_join_set_tracer`]`, tasks and closures
are executed
Review Comment:
🤦
```suggestion
/// If no tracer is injected via [`set_join_set_tracer`], tasks and closures
are executed
```
I should have had the AI do this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
