jayshrivastava commented on PR #23187: URL: https://github.com/apache/datafusion/pull/23187#issuecomment-4928552008
@Rich-T-kid Your optimization relies on the pointer being the same, generally, what are the odds of that? I suggested earlier to count how many times `.unwrap_or(null_sentinel_index)` is used and if theres no null keys, skip the concat. Is that more or less likely? One way to find out is to run the benches and print out how many times each of those things happen, assuming there's enough interesting cases in the benches. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
