github-advanced-security[bot] commented on code in PR #4840:
URL: https://github.com/apache/datafusion-comet/pull/4840#discussion_r3531806600
##########
.github/workflows/ci.yml:
##########
@@ -295,15 +302,35 @@
iceberg_1_10:
name: Iceberg Spark SQL Tests (Iceberg 1.10)
needs: changes
+ # Main-only by default; PRs need the `run-iceberg-tests` label. Iceberg
1.11
+ # (Spark 4.1) is the PR-gated Iceberg job; 1.10 covers the Spark 3.5 path.
if: |
needs.changes.outputs.iceberg_1_10 == 'true' &&
(github.event_name == 'push' ||
github.event_name == 'workflow_dispatch' ||
- github.event_name == 'pull_request')
+ (github.event_name == 'pull_request' &&
+ contains(github.event.pull_request.labels.*.name,
'run-iceberg-tests')))
uses: ./.github/workflows/iceberg_spark_test_reusable.yml
with:
iceberg-short: '1.10'
iceberg-full: '1.10.0'
spark-short: '3.5'
spark-full: '3.5.8'
java: 17
+
+ iceberg_1_11:
+ name: Iceberg Spark SQL Tests (Iceberg 1.11)
+ needs: changes
+ # Runs on every PR: Iceberg 1.11 is our only Spark 4.1 Iceberg coverage.
+ if: |
+ needs.changes.outputs.iceberg_1_11 == 'true' &&
+ (github.event_name == 'push' ||
+ github.event_name == 'workflow_dispatch' ||
+ github.event_name == 'pull_request')
+ uses: ./.github/workflows/iceberg_spark_test_reusable.yml
+ with:
+ iceberg-short: '1.11'
+ iceberg-full: '1.11.0'
+ spark-short: '4.1'
+ spark-full: '4.1.2'
+ java: 17
Review Comment:
## CodeQL / Workflow does not contain permissions
Actions job or workflow does not limit the permissions of the GITHUB_TOKEN.
Consider setting an explicit permissions block, using the following as a
minimal starting point: {{}}
[Show more
details](https://github.com/apache/datafusion-comet/security/code-scanning/119)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
