jayzhan211 commented on code in PR #11845:
URL: https://github.com/apache/datafusion/pull/11845#discussion_r1706274728
##########
datafusion/physical-expr-functions-aggregate/src/aggregate.rs:
##########
@@ -15,34 +15,25 @@
// specific language governing permissions and limitations
// under the License.
-use std::fmt::Debug;
-use std::{any::Any, sync::Arc};
-
use arrow::datatypes::{DataType, Field, Schema, SchemaRef};
-
-use datafusion_common::exec_err;
use datafusion_common::{internal_err, not_impl_err, DFSchema, Result};
use datafusion_expr::expr::create_function_physical_name;
-use datafusion_expr::function::StateFieldsArgs;
-use datafusion_expr::type_coercion::aggregates::check_arg_count;
-use datafusion_expr::utils::AggregateOrderSensitivity;
+use datafusion_expr::AggregateUDF;
Review Comment:
Maybe we should remove `call()`, but create another function like
`aggregate_expr(sum_udaf(), vec![args]) -> Expr`
And, `aggregate_physical_expr(sum_udaf(), vec![physical_args]) -> Arc<dyn
AggregateExpr>>` similarly. 🤔
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
