dinmukhamedm commented on code in PR #2385:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/2385#discussion_r3493254187
##########
tests/sqlparser_common.rs:
##########
@@ -10834,8 +10864,11 @@ fn parse_position() {
#[test]
fn parse_position_negative() {
+ // Dialects that accept an unparenthesized IN right-hand side (e.g.
ClickHouse)
+ // report a different error here, so exclude them.
let sql = "SELECT POSITION(foo IN) from bar";
- let res = parse_sql_statements(sql);
+ let res =
+ all_dialects_except(|d|
d.supports_in_unparenthesized_expr()).parse_sql_statements(sql);
assert_eq!(
ParserError::ParserError("Expected: (, found: )".to_string()),
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
