wForget commented on code in PR #4734:
URL: https://github.com/apache/datafusion-comet/pull/4734#discussion_r3490875599
##########
spark/src/main/scala/org/apache/spark/Plugins.scala:
##########
@@ -148,12 +152,32 @@ object CometDriverPlugin extends Logging {
}
}
+class CometExecutorPlugin extends ExecutorPlugin with Logging {
+
+ override def init(ctx: PluginContext, extraConf: ju.Map[String, String]):
Unit = {
+ logInfo("CometExecutorPlugin init")
+
+ super.init(ctx, extraConf)
+ }
+
+ override def shutdown(): Unit = {
+ logInfo("CometExecutorPlugin shutdown")
Review Comment:
I added an atomic released var to ensure it is called only once, to avoid
issues caused by double release when we extend the release method on native
side later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
