Kevin-Li-2025 commented on PR #23065: URL: https://github.com/apache/datafusion/pull/23065#issuecomment-4826342350
Addressed the primitive specialization feedback by adding a native primitive any_value groups accumulator for numeric, decimal, temporal, and timestamp types. The new path stores group state as a native Vec<T::Native> plus the existing is_set bitmap, and only falls back to the ScalarValue-based accumulator for non-primitive/complex types. This keeps the existing generic behavior while avoiding per-group ScalarValue state for the common primitive cases. Validation run locally: - cargo fmt --check - cargo test -p datafusion-functions-aggregate any_value --lib - git diff --check -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
