LiaCastaneda commented on code in PR #23003:
URL: https://github.com/apache/datafusion/pull/23003#discussion_r3441128925


##########
benchmarks/README.md:
##########
@@ -598,6 +598,14 @@ In addition, topk_tpch is available from the bench.sh 
script:
 ./bench.sh run topk_tpch
 ```
 
+To benchmark TopK queries on pre-sorted TPC-H input, use:

Review Comment:
   There is a dead link in the `## Sort TPCH ` maybe we can fix it in this PR?
   
   > If the TPCH tables have been converted as sorted on their first column 
(see [Sorted Conversion](#sorted-conversion)), you can use the `--sorted` flag 
to indicate that the input data is pre-sorted, allowing DataFusion to leverage 
that order during query execution.
   
   `Sorted Conversion` does not exist
   
   it's not clear to me if data is already sorted or it is sorted when we 
specify `--sorted`, sounds like `--sorted` just tells the planner the input 
data is pre sorted



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to