github-actions[bot] commented on PR #22969: URL: https://github.com/apache/datafusion/pull/22969#issuecomment-4715536704
<!-- semver-check-comment --> Thank you for opening this pull request! Reviewer note: [cargo-semver-checks](https://github.com/obi1kenobi/cargo-semver-checks) reported the current version number is not SemVer-compatible with the changes in this pull request (compared against the base branch). <details> <summary>Details</summary> ``` Cloning apache/main Building datafusion v54.0.0 (current) Built [ 101.588s] (current) Parsing datafusion v54.0.0 (current) Parsed [ 0.038s] (current) Building datafusion v54.0.0 (baseline) Built [ 101.840s] (baseline) Parsing datafusion v54.0.0 (baseline) Parsed [ 0.039s] (baseline) Checking datafusion v54.0.0 -> v54.0.0 (no change; assume patch) Checked [ 0.950s] 223 checks: 223 pass, 30 skip Summary no semver update required Finished [ 206.500s] datafusion Building datafusion-catalog-listing v54.0.0 (current) Built [ 45.466s] (current) Parsing datafusion-catalog-listing v54.0.0 (current) Parsed [ 0.013s] (current) Building datafusion-catalog-listing v54.0.0 (baseline) Built [ 45.609s] (baseline) Parsing datafusion-catalog-listing v54.0.0 (baseline) Parsed [ 0.013s] (baseline) Checking datafusion-catalog-listing v54.0.0 -> v54.0.0 (no change; assume patch) Checked [ 0.117s] 223 checks: 221 pass, 2 fail, 0 warn, 30 skip --- failure inherent_method_missing: pub method removed or renamed --- Description: A publicly-visible method or associated fn is no longer available under its prior name. It may have been renamed or removed entirely. ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.48.0/src/lints/inherent_method_missing.ron Failed in: ListingOptions::with_session_config_options, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/10dd6859077d8f07442b4f21d0f442f7d0301006/datafusion/catalog-listing/src/options.rs:89 ListingOptions::with_collect_stat, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/10dd6859077d8f07442b4f21d0f442f7d0301006/datafusion/catalog-listing/src/options.rs:220 ListingOptions::with_target_partitions, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/10dd6859077d8f07442b4f21d0f442f7d0301006/datafusion/catalog-listing/src/options.rs:237 --- failure struct_pub_field_missing: pub struct's pub field removed or renamed --- Description: A publicly-visible struct has at least one public field that is no longer available under its prior name. It may have been renamed or removed entirely. ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.48.0/src/lints/struct_pub_field_missing.ron Failed in: field collect_stat of struct ListingOptions, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/10dd6859077d8f07442b4f21d0f442f7d0301006/datafusion/catalog-listing/src/options.rs:44 field target_partitions of struct ListingOptions, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/10dd6859077d8f07442b4f21d0f442f7d0301006/datafusion/catalog-listing/src/options.rs:47 Summary semver requires new major version: 2 major and 0 minor checks failed Finished [ 92.484s] datafusion-catalog-listing Building datafusion-proto v54.0.0 (current) Built [ 60.099s] (current) Parsing datafusion-proto v54.0.0 (current) Parsed [ 0.021s] (current) Building datafusion-proto v54.0.0 (baseline) Built [ 58.414s] (baseline) Parsing datafusion-proto v54.0.0 (baseline) Parsed [ 0.021s] (baseline) Checking datafusion-proto v54.0.0 -> v54.0.0 (no change; assume patch) Checked [ 0.399s] 223 checks: 223 pass, 30 skip Summary no semver update required Finished [ 121.081s] datafusion-proto Building datafusion-proto-models v54.0.0 (current) Built [ 24.104s] (current) Parsing datafusion-proto-models v54.0.0 (current) Parsed [ 0.133s] (current) Building datafusion-proto-models v54.0.0 (baseline) Built [ 24.922s] (baseline) Parsing datafusion-proto-models v54.0.0 (baseline) Parsed [ 0.135s] (baseline) Checking datafusion-proto-models v54.0.0 -> v54.0.0 (no change; assume patch) Checked [ 2.631s] 223 checks: 222 pass, 1 fail, 0 warn, 30 skip --- failure struct_pub_field_missing: pub struct's pub field removed or renamed --- Description: A publicly-visible struct has at least one public field that is no longer available under its prior name. It may have been renamed or removed entirely. ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.48.0/src/lints/struct_pub_field_missing.ron Failed in: field collect_stat of struct ListingTableScanNode, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/10dd6859077d8f07442b4f21d0f442f7d0301006/datafusion/proto-models/src/generated/prost.rs:123 field target_partitions of struct ListingTableScanNode, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/10dd6859077d8f07442b4f21d0f442f7d0301006/datafusion/proto-models/src/generated/prost.rs:125 field collect_stat of struct ListingTableScanNode, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/10dd6859077d8f07442b4f21d0f442f7d0301006/datafusion/proto-models/src/generated/prost.rs:123 field target_partitions of struct ListingTableScanNode, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/10dd6859077d8f07442b4f21d0f442f7d0301006/datafusion/proto-models/src/generated/prost.rs:125 Summary semver requires new major version: 1 major and 0 minor checks failed Finished [ 53.542s] datafusion-proto-models ``` </details> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
