martin-g commented on code in PR #22951:
URL: https://github.com/apache/datafusion/pull/22951#discussion_r3414153770
##########
Cargo.toml:
##########
@@ -151,7 +151,7 @@ datafusion-physical-expr-adapter = { path =
"datafusion/physical-expr-adapter",
datafusion-physical-expr-common = { path = "datafusion/physical-expr-common",
version = "54.0.0", default-features = false }
datafusion-physical-optimizer = { path = "datafusion/physical-optimizer",
version = "54.0.0" }
datafusion-physical-plan = { path = "datafusion/physical-plan", version =
"54.0.0" }
-datafusion-proto = { path = "datafusion/proto", version = "54.0.0" }
+datafusion-proto = { path = "datafusion/proto", version = "54.0.0",
default-features = false }
Review Comment:
This changes the default behavior for all members of the workspace, no just
for -ffi. Is this intentional ?
The -ffi crate already does it at
https://github.com/apache/datafusion/pull/22951/changes#diff-c3dbf9bcba2d884b87eb3587e66d470700dd7e8e75f1630765e1da4b42a81c5aR66
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
