EmilyMatt commented on code in PR #22945:
URL: https://github.com/apache/datafusion/pull/22945#discussion_r3412917284
##########
datafusion/physical-plan/src/sorts/multi_level_merge.rs:
##########
@@ -182,7 +191,17 @@ impl MultiLevelMergeBuilder {
async fn create_stream(mut self) -> Result<SendableRecordBatchStream> {
Review Comment:
I prefer not to as this complicates the code, I don't really have a
guarantee that the last stream is not a part of a merge with the results of the
first streams, as there can be multiple levels, I don't wanna fuck with that
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
