kosiew commented on PR #22639:
URL: https://github.com/apache/datafusion/pull/22639#issuecomment-4707010768
@Jefffrey
Thanks for the feedback. I've updated the approach accordingly:
* Removed the new
`functions-aggregate-common::aggregate::groups_accumulator::avg` module and
kept the implementation within the existing AVG codepath.
* Folded Spark grouped AVG into a built-in AVG grouped accumulator
implementation
* Preserved the existing state contracts:
* Spark AVG: `[sum, count]` with `Int64` counts
* Built-in AVG: `[count, sum]` with `UInt64` counts
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]