jayzhan211 commented on code in PR #11795:
URL: https://github.com/apache/datafusion/pull/11795#discussion_r1702939862
##########
datafusion/expr/src/test/function_stub.rs:
##########
@@ -326,7 +326,7 @@ impl Default for Min {
impl Min {
pub fn new() -> Self {
Self {
- aliases: vec!["min".to_string()],
Review Comment:
We don't need uppercase alias.
To use uppercase alias the query is something like `select "MAX"(a) from
t;`, which is uncommon.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
