martin-g commented on PR #1852: URL: https://github.com/apache/datafusion-ballista/pull/1852#issuecomment-4673754250
I played with some new Github UI button that resolved in one click all my comments. There was no way to undo/unresolve :-) I agree with @milenkovicm that only ids should have their own types. I think even the executor_id should be ExecutorId(Uuid). Uuid is an implementation detail. It might change to Ulid later if needed and the places using ExecutorId won't notice. Or if another Id type is introduced that is also based on Uuid. It would be good to use different (new)types for them, to not mix them. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
