Sean-Kenneth-Doherty commented on PR #22303: URL: https://github.com/apache/datafusion/pull/22303#issuecomment-4558931521
Addressed @Jefffrey’s review comments in `7440978d2`: - replaced the one-off `DateTruncGranularity::as_str()` helper with a `Display` implementation - moved the lower-bound `date_trunc` SQL regression into `datafusion/sqllogictest/test_files/datetime/timestamps.slt` - removed the standalone `date_trunc_boundaries.slt` file Validation: - `cargo fmt --all --check` - `git diff --check` - `CARGO_BUILD_JOBS=2 cargo test -p datafusion-functions --lib date_trunc_out_of_range_lower_bound_returns_error` - `CARGO_BUILD_JOBS=2 cargo test -p datafusion-sqllogictest --test sqllogictests -- datetime/timestamps.slt` (`1/1 files completed`) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
