adriangb commented on PR #22372: URL: https://github.com/apache/datafusion/pull/22372#issuecomment-4527262657
> If I used `with_table_partition_cols` I would expect partition_cols to be ultimately thing that rewrites `self.table_partition_cols` with incoming `partition_cols`. However the method adding them to already existing. That's a good point. The builder API for a mutable `Vec<..>` field could go one of two ways: append or replace. My intuition is that we should make it clear which one it is. I don't think there are any tests or uses of appending internally, so I would suggest we just error if the existing list is non-empty. @Dandandan @comphead wdyt? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
