andygrove commented on code in PR #736:
URL: https://github.com/apache/datafusion-comet/pull/736#discussion_r1697613486
##########
spark/src/test/scala/org/apache/comet/exec/CometExecSuite.scala:
##########
@@ -1466,7 +1466,7 @@ class CometExecSuite extends CometTestBase {
SQLConf.ADAPTIVE_EXECUTION_ENABLED.key -> aqeEnabled) {
withParquetTable((0 until 10).map(i => (i, 10 - i)), "t1") { // TODO:
test nulls
val aggregateFunctions =
- List("MAX(_1)", "MIN(_1)") // TODO: Test all the aggregates
+ List("COUNT(_1)", "MAX(_1)", "MIN(_1)") // TODO: Test all the
aggregates
Review Comment:
Is `count(*)` also valid in this context? Could you add a test if it is
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
