tinfoil-knight commented on code in PR #11733: URL: https://github.com/apache/datafusion/pull/11733#discussion_r1697580548
########## datafusion/optimizer/src/simplify_expressions/utils.rs: ########## Review Comment: Doesn't handle all possible positions currently for the expression. Eg: `(i + 1) + 2`; `i + 1 + 2` will resolve to `i + 3` But something like these won't `(1 + i) + 2` `2 + (i + 1)` `2 + (1 + i)` `1 + 2 + i` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
