andygrove commented on code in PR #22404: URL: https://github.com/apache/datafusion/pull/22404#discussion_r3277688367
########## datafusion/sqllogictest/test_files/spark/array/slice.slt: ########## @@ -137,3 +137,13 @@ query ? SELECT slice(slice(make_array(NULL), 1, 2), 1, 2) ---- [NULL] + Review Comment: Could be worht adding a regression test for the boundary case where adjusted_start lands at exactly 0: ```sql SELECT slice([1, 2, 3, 4], -5, 2); -- expected: [] ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
