parthchandra commented on code in PR #732:
URL: https://github.com/apache/datafusion-comet/pull/732#discussion_r1697327613
##########
common/src/main/java/org/apache/comet/vector/CometPlainVector.java:
##########
@@ -153,11 +153,7 @@ public CDataDictionaryProvider getDictionaryProvider() {
@Override
public boolean isNullAt(int rowId) {
- if (this.valueBufferAddress == -1) {
- return true;
- } else {
- return super.isNullAt(rowId);
- }
+ return this.valueBufferAddress == -1 || super.isNullAt(rowId);
Review Comment:
interesting find
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
