adriangb opened a new pull request, #22346:
URL: https://github.com/apache/datafusion/pull/22346

   ## Which issue does this PR close?
   
   Relates to the discussion in #22024 about the Parquet datasource crate 
becoming hard to navigate. Split out of #22156, which bundled several 
code-motion moves into one PR — this is one of three smaller, 
independently-reviewable PRs that replace it.
   
   ## Rationale for this change
   
   `opener.rs` had grown to ~2,700 LOC, bundling several distinct 
responsibilities into one file. That makes it hard to read and hard to review 
changes in isolation. This PR is **pure code motion**: no behavior change and 
no public API change.
   
   ## What changes are included in this PR?
   
   Splits `opener.rs` into an `opener/` directory module:
   
   - `opener/early_stop.rs` — `EarlyStoppingStream`, the dynamic-filter 
early-termination wrapper applied at the end of `build_stream`.
   - `opener/encryption.rs` — `EncryptionContext` and the 
`ParquetMorselizer::get_encryption_context` helpers, isolating the 
`#[cfg(feature = "parquet_encryption")]` gating that previously bled through 
the main file.
   
   `opener.rs` becomes `opener/mod.rs`.
   
   Note: #22156 originally also extracted an `opener/push_decoder_stream.rs`. 
That move is now obsolete — #22289 has since extracted `PushDecoderStreamState` 
into `push_decoder.rs` — so it is dropped here.
   
   ## Are these changes tested?
   
   Yes, covered by existing tests. `cargo test -p datafusion-datasource-parquet 
--all-features` (122 passing) and `cargo clippy -p 
datafusion-datasource-parquet --all-targets --all-features -- -D warnings` both 
pass.
   
   ## Are there any user-facing changes?
   
   No. `opener` was already a private module; this only reorganizes files 
inside the crate.
   
   🤖 Generated with [Claude Code](https://claude.com/claude-code)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to