alamb opened a new pull request, #22345:
URL: https://github.com/apache/datafusion/pull/22345

   
   
   ## Which issue does this PR close?
   
   - Closes https://github.com/apache/datafusion/issues/22073
   
   ## Rationale for this change
   
   As @cetra3 describes on https://github.com/apache/datafusion/issues/22073, 
in https://github.com/apache/datafusion/pull/21743 @berkaysynnada  made a 
seemingly small change to align to postgres semantics that had much larger 
consequences 
   
   I think many users (for example @cetra3) will treat this change as a 
regression, and thus I think this issue would block the next datafusion release
   - https://github.com/apache/datafusion/issues/21080
   
   We tried an alternate fix but it appears to also raise some subtle questions 
from @Jefffrey 
   - https://github.com/apache/datafusion/pull/22102#issuecomment-4451305175
   
   Thus I think it is safest to revert the initial change and work out the 
better longer term fix before releasing
   
   ## What changes are included in this PR?
   - Revert https://github.com/apache/datafusion/pull/21743 / 
4bff17ebd2394e319b4adee77df18a011116ff2d until we can have a beter
   
   ## Are these changes tested?
   
   <!--
   We typically require tests for all PRs in order to:
   1. Prevent the code from being accidentally broken by subsequent changes
   2. Serve as another way to document the expected behavior of the code
   
   If tests are not included in your PR, please explain why (for example, are 
they covered by existing tests)?
   -->
   
   ## Are there any user-facing changes?
   
   <!--
   If there are user-facing changes then we may require documentation to be 
updated before approving the PR.
   -->
   
   <!--
   If there are any breaking changes to public APIs, please add the `api 
change` label.
   -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to