mailmindlin commented on code in PR #22157:
URL: https://github.com/apache/datafusion/pull/22157#discussion_r3259475305
##########
datafusion/ffi/src/execution_plan.rs:
##########
@@ -74,6 +75,15 @@ pub struct FFI_ExecutionPlan {
/// underlying [`ExecutionPlan::metrics`] returned `None`.
pub metrics: unsafe extern "C" fn(plan: &Self) ->
FFI_Option<FFI_MetricsSet>,
+ /// Snapshot partition statistics. `partition == None` corresponds to
+ /// statistics over all partitions; `Some(idx)` corresponds to a specific
+ /// partition. The returned bytes are a prost-encoded
+ /// `datafusion_proto_common::Statistics`.
+ pub partition_statistics: unsafe extern "C" fn(
+ plan: &Self,
+ partition: FFI_Option<u64>,
Review Comment:
I wonder if it's a HTML sanitizer bug. It was a deliberate choice to use
`u64` because I wasn't sure that `FFI_Option<usize>` was safe for FFI, in case
usize is different on both sides. Let me check how the FFI negotiation works
real quick first.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
