killzoner commented on PR #1685:
URL:
https://github.com/apache/datafusion-ballista/pull/1685#issuecomment-4478300173
> > You added standalone push scheduler, but this is not covered by tests
ATM ?
>
> added coverage in `context_setup.rs`:
`standalone_push_scheduling_executes_sql` starts the standalone
scheduler/executor with push scheduling and verifies a real SQL query against
it...
Sorry, not quite what I meant. I meant having 0 change on the test cases
themselves, and just splitting what you did to
```rust
#[fixture]
async fn remote(
#[values(TaskSchedulingPolicy::PullStaged,
TaskSchedulingPolicy::PushStaged)]
policy: TaskSchedulingPolicy,
) -> SessionContext {
common::remote_context_with_scheduling(policy).await
}
```
and the same for `standalone`.
This way you keep the 2 remote vs standalone, do 0 change on the existing
code, and cover pull / push for both paths.
Also now you have diverging code style with
`ballista/client/tests/context_unsupported.rs`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
