wiedld commented on PR #11665: URL: https://github.com/apache/datafusion/pull/11665#issuecomment-2256916459
[CI was failing due to the concat of error messages](https://github.com/apache/datafusion/pull/11665#issuecomment-2256764400). I fixed it two ways -- in order to demonstrate why the 2nd way is better. * 1st way is to [splice the error message,](https://github.com/apache/datafusion/pull/11665/commits/09b20d289f53d3b61b976313f8731e8a6711f370) in order to insert the consumer. This inherently violates the nature of error bubbling IMO. * 2nd way is to [wrap the OOM error with the top consumers](https://github.com/apache/datafusion/pull/11665/commits/f75764e9de36c4d336a6f84203c95a460a9d3610). IMO this is correct. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
