jonahgao opened a new pull request, #11693: URL: https://github.com/apache/datafusion/pull/11693
## Which issue does this PR close? <!-- We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123. --> Closes #11621. ## Rationale for this change Given an example query: ```sql SELECT * FROM t1 JOIN t2 ON t1.v1 = t2.v1 WHERE (t1.v1 == t2.v1) OR t1.v1 ``` When removing the join predicate `t1.v1 = t2.v1` from the parent filter `(t1.v1 == t2.v1) OR t1.v1`, this process can be considered as replacing the join predicate with `true`. The result should be `TRUE OR t1.v1` and further simplified to empty, but currently, it is `t1.v1`. This will lead to incorrect join results. ## What changes are included in this PR? <!-- There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR. --> ## Are these changes tested? Yes ## Are there any user-facing changes? No -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
