alamb commented on code in PR #11678:
URL: https://github.com/apache/datafusion/pull/11678#discussion_r1693499951
##########
datafusion/core/src/physical_optimizer/sort_pushdown.rs:
##########
@@ -176,6 +176,7 @@ fn pushdown_requirement_to_children(
|| plan.as_any().is::<ProjectionExec>()
|| is_limit(plan)
|| plan.as_any().is::<HashJoinExec>()
+ || pushdown_would_violate_requirements(parent_required, plan.as_ref())
Review Comment:
In general it would be great to avoid these explicit checks for types over
time in favor of functions on the ExecutionPlan nodes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
