xiedeyantu commented on PR #21715: URL: https://github.com/apache/datafusion/pull/21715#issuecomment-4380411593
> What about taking a different approach here: I'd argue a UNIQUE constraint on a nullable column should not be an FD in the first place. Rather than producing such constraints and then filtering them out in the various places that use the FDs, why not change `new_from_constraints` to not return an FD in this circumstance to begin with? I've tried making the modifications based on your suggestions; please check if they meet your requirements. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
