github-actions[bot] commented on PR #20763: URL: https://github.com/apache/datafusion/pull/20763#issuecomment-4379209597
<!-- semver-check-comment --> Thank you for opening this pull request! Reviewer note: [cargo-semver-checks](https://github.com/obi1kenobi/cargo-semver-checks) reported the current version number is not SemVer-compatible with the changes in this pull request (compared against the base branch). <details> <summary>Details</summary> ``` Cloning apache/main Building datafusion-expr v53.1.0 (current) Built [ 29.444s] (current) Parsing datafusion-expr v53.1.0 (current) Parsed [ 0.073s] (current) Building datafusion-expr v53.1.0 (baseline) Built [ 26.965s] (baseline) Parsing datafusion-expr v53.1.0 (baseline) Parsed [ 0.071s] (baseline) Checking datafusion-expr v53.1.0 -> v53.1.0 (no change; assume patch) Checked [ 1.324s] 222 checks: 220 pass, 2 fail, 0 warn, 30 skip --- failure auto_trait_impl_removed: auto trait no longer implemented --- Description: A public type has stopped implementing one or more auto traits. This can break downstream code that depends on the traits being implemented. ref: https://doc.rust-lang.org/reference/special-types-and-traits.html#auto-traits impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.47.0/src/lints/auto_trait_impl_removed.ron Failed in: type WriteOp is no longer UnwindSafe, in /home/runner/work/datafusion/datafusion/datafusion/expr/src/logical_plan/dml.rs:231 type WriteOp is no longer RefUnwindSafe, in /home/runner/work/datafusion/datafusion/datafusion/expr/src/logical_plan/dml.rs:231 type WriteOp is no longer UnwindSafe, in /home/runner/work/datafusion/datafusion/datafusion/expr/src/logical_plan/dml.rs:231 type WriteOp is no longer RefUnwindSafe, in /home/runner/work/datafusion/datafusion/datafusion/expr/src/logical_plan/dml.rs:231 type WriteOp is no longer UnwindSafe, in /home/runner/work/datafusion/datafusion/datafusion/expr/src/logical_plan/dml.rs:231 type WriteOp is no longer RefUnwindSafe, in /home/runner/work/datafusion/datafusion/datafusion/expr/src/logical_plan/dml.rs:231 type WriteOp is no longer UnwindSafe, in /home/runner/work/datafusion/datafusion/datafusion/expr/src/logical_plan/dml.rs:231 type WriteOp is no longer RefUnwindSafe, in /home/runner/work/datafusion/datafusion/datafusion/expr/src/logical_plan/dml.rs:231 --- failure enum_variant_added: enum variant added on exhaustive enum --- Description: A publicly-visible enum without #[non_exhaustive] has a new variant. ref: https://doc.rust-lang.org/cargo/reference/semver.html#enum-variant-new impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.47.0/src/lints/enum_variant_added.ron Failed in: variant WriteOp:MergeInto in /home/runner/work/datafusion/datafusion/datafusion/expr/src/logical_plan/dml.rs:243 variant WriteOp:MergeInto in /home/runner/work/datafusion/datafusion/datafusion/expr/src/logical_plan/dml.rs:243 variant WriteOp:MergeInto in /home/runner/work/datafusion/datafusion/datafusion/expr/src/logical_plan/dml.rs:243 variant WriteOp:MergeInto in /home/runner/work/datafusion/datafusion/datafusion/expr/src/logical_plan/dml.rs:243 Summary semver requires new major version: 2 major and 0 minor checks failed Finished [ 59.254s] datafusion-expr Building datafusion-proto v53.1.0 (current) Built [ 55.402s] (current) Parsing datafusion-proto v53.1.0 (current) Parsed [ 0.135s] (current) Building datafusion-proto v53.1.0 (baseline) Built [ 54.763s] (baseline) Parsing datafusion-proto v53.1.0 (baseline) Parsed [ 0.135s] (baseline) Checking datafusion-proto v53.1.0 -> v53.1.0 (no change; assume patch) Checked [ 1.897s] 222 checks: 220 pass, 2 fail, 0 warn, 30 skip --- failure constructible_struct_adds_field: externally-constructible struct adds field --- Description: A pub struct constructible with a struct literal has a new pub field. Existing struct literals must be updated to include the new field. ref: https://doc.rust-lang.org/reference/expressions/struct-expr.html impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.47.0/src/lints/constructible_struct_adds_field.ron Failed in: field DmlNode.merge_into in /home/runner/work/datafusion/datafusion/datafusion/proto/src/generated/prost.rs:438 field DmlNode.merge_into in /home/runner/work/datafusion/datafusion/datafusion/proto/src/generated/prost.rs:438 --- failure enum_variant_added: enum variant added on exhaustive enum --- Description: A publicly-visible enum without #[non_exhaustive] has a new variant. ref: https://doc.rust-lang.org/cargo/reference/semver.html#enum-variant-new impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.47.0/src/lints/enum_variant_added.ron Failed in: variant Type:MergeInto in /home/runner/work/datafusion/datafusion/datafusion/proto/src/generated/prost.rs:462 variant Type:MergeInto in /home/runner/work/datafusion/datafusion/datafusion/proto/src/generated/prost.rs:462 Summary semver requires new major version: 2 major and 0 minor checks failed Finished [ 115.182s] datafusion-proto ``` </details> <!-- semver-check-comment --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
