andygrove opened a new pull request, #4204: URL: https://github.com/apache/datafusion-comet/pull/4204
## Which issue does this PR close? Closes #4137. ## Rationale for this change The `CachedBatchSerializerNoUnwrapSuite` test in Spark 4.1.1 asserts that, under `DefaultCachedBatchSerializerNoUnwrap`, the cached plan retains a row-conversion operator on top of its columnar scan. With Comet enabled, Comet replaces Spark's `ColumnarToRowExec` with `CometNativeColumnarToRow` (over `CometNativeScan`), which preserves the serializer's intended "don't unwrap" semantics but differs in class identity from the assertion. ## What changes are included in this PR? - Update the 4.1.1 diff so the cached-plan assertion accepts either the Spark shape (`WholeStageCodegenExec(ColumnarToRowExec(...))`) or the equivalent Comet shape (any `org.apache.spark.sql.comet.*` plan node). - Remove the IgnoreComet tag on the test. ## How are these changes tested? Ran `CachedBatchSerializerNoUnwrapSuite` locally against Spark 4.1.1 with Comet enabled — test passes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
