parthchandra commented on code in PR #705:
URL: https://github.com/apache/datafusion-comet/pull/705#discussion_r1688697138
##########
common/src/main/java/org/apache/comet/vector/CometDictionary.java:
##########
@@ -83,6 +82,18 @@ public byte[] decodeToBinary(int index) {
case FIXEDSIZEBINARY:
return values.getBinary(index);
case DECIMAL:
+ if (binaries == null) {
Review Comment:
I wonder if this need to be made thread safe?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
