coderfender commented on PR #21453: URL: https://github.com/apache/datafusion/pull/21453#issuecomment-4273007639
@Jefffrey , the catch between `approx_distinct` and `count_distinct` is that the former returns an unsigned int while the latter returns a signed one (hence the need for my wrapper) . As much as this does not make a difference, I wanted to tackle that problem in a separate PR and go ahead with this wrapper approach. Using `simplify` means that I would have to try and cast to signed ints which shouldnt add too much overhead though . Let me push a commit and bench it -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
