andygrove opened a new pull request, #3974: URL: https://github.com/apache/datafusion-comet/pull/3974
## Which issue does this PR close? Closes #. ## Rationale for this change We already have a `review-comet-pr` skill that helps reviewers check PRs in this repo for Spark compatibility and implementation correctness. A similar workflow applies when reviewing PRs in the upstream `apache/datafusion` repository, particularly for the `datafusion-spark` compatible function library and for core DataFusion changes that may affect Comet. The upstream repo has a different test approach. It uses `.slt` (sqllogictest) files written in DataFusion SQL syntax, so the tests cannot be run directly in Spark. A reviewer needs to manually run equivalent queries in Spark to verify that the DataFusion implementation produces the same result. This skill packages that workflow so it is consistent across reviews and so new reviewers have a concrete checklist to follow. ## What changes are included in this PR? Adds a new Claude Code skill at `.claude/skills/review-datafusion-pr/SKILL.md`. The skill covers: - PR classification into a Spark expression track, a Comet API impact track, or both - Reading the Spark source and Spark tests as the canonical reference for expression behavior - Reviewing the Rust implementation under `datafusion/spark/src/function/` - Reviewing the `.slt` test file against the testing guide in `datafusion/sqllogictest/test_files/spark/README.md` - A manual Spark cross-check step with translation notes from DataFusion SQL to Spark SQL, since `.slt` tests cannot prove Spark equivalence on their own - A checklist for breaking API changes in the DataFusion crates that Comet depends on (`datafusion`, `datafusion-datasource`, `datafusion-physical-expr-adapter`, `datafusion-spark`) - CI status, documentation, and common review issues ## How are these changes tested? Manual review of the skill content. The skill is guidance for human reviewers and is not executed by CI. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
