2010YOUY01 commented on code in PR #11587:
URL: https://github.com/apache/datafusion/pull/11587#discussion_r1686678665
##########
datafusion/physical-plan/src/coalesce_batches.rs:
##########
@@ -216,6 +218,8 @@ impl CoalesceBatchesStream {
match input_batch {
Poll::Ready(x) => match x {
Some(Ok(batch)) => {
+ let batch = gc_string_view_batch(&batch);
Review Comment:
So here inside `gc` string buffer will be copied once, (below) in
`concat_batches()` string buffer will be copied again, it seems possible to
copy only once by changing the internal implementation of `concat_batches()`
But I think we can do it later when there is a good benchmark to assess the
impact, at least excessive copy in `coalesce_batches()` does not have a huge
performance impact on TPCH now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
