asolimando commented on code in PR #21549: URL: https://github.com/apache/datafusion/pull/21549#discussion_r3069132135
########## datafusion/sqllogictest/test_files/eliminate_outer_join.slt: ########## @@ -198,6 +198,133 @@ select * from t1 left join t2 on t1.a = t2.x where t2.x in (1, 2) or t2.x is nul 3 30 c NULL NULL NULL NULL 40 d NULL NULL NULL +### Review Comment: Feel free to ping me if an extra set of eyes is needed to check similar generalized APIs, I agree they are very useful, and they are also battle tested -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
