neilconway commented on PR #21420: URL: https://github.com/apache/datafusion/pull/21420#issuecomment-4201221754
> It might be worth adding unit tests for sliced StringViewArray inputs (non-zero offset) and results landing exactly at the 12-byte inline/out-of-line boundary. These are the two spots most likely to surface issues with the unsafe view construction. > > Other than that, nice optimization. Thanks! Added some tests for those cases. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
