parthchandra commented on code in PR #693:
URL: https://github.com/apache/datafusion-comet/pull/693#discussion_r1685082141
##########
common/src/main/spark-3.3/org/apache/comet/shims/ShimBatchReader.scala:
##########
@@ -19,8 +19,12 @@
package org.apache.comet.shims
+import scala.collection.mutable
+
+import org.apache.spark.executor.TaskMetrics
import org.apache.spark.sql.catalyst.InternalRow
import org.apache.spark.sql.execution.datasources.PartitionedFile
+import org.apache.spark.util.AccumulatorV2
object ShimBatchReader {
Review Comment:
I believe we tend to put the methods in the class they are used. Anyway, let
me move this to `BatchReader` and avoid the code duplication.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
