alamb commented on code in PR #20598:
URL: https://github.com/apache/datafusion/pull/20598#discussion_r2983948370
##########
datafusion/sqllogictest/README.md:
##########
@@ -75,24 +75,25 @@ RUST_LOG=debug cargo test --test sqllogictests -- ddl
The sqllogictest runner can emit deterministic per-file elapsed timings to help
identify slow test files.
-By default (`--timing-summary auto`), timing summary output is disabled in
local
-TTY runs and shows a top-slowest summary in non-TTY/CI runs.
+Timing summary output is disabled by default and enabled with
+`--timing-summary` (or `SLT_TIMING_SUMMARY=1`).
Review Comment:
```suggestion
`--timing-summary` (or `SLT_TIMING_SUMMARY=true`).
```
I think this should be `SLT_TIMING_SUMMARY=true` as using this example will
result in an error
```
SLT_TIMING_SUMMARY=1 cargo test --profile=ci --test sqllogictests
Finished `ci` profile [unoptimized] target(s) in 0.28s
Running bin/sqllogictests.rs
(target/ci/deps/sqllogictests-7e2a8cc6115b158a)
error: invalid value '1' for '--timing-summary'
[possible values: true, false]
```
This works nicely
```shell
SLT_TIMING_SUMMARY=true cargo test --profile=ci --test sqllogictests
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
