vaibhawvipul commented on PR #3759: URL: https://github.com/apache/datafusion-comet/pull/3759#issuecomment-4120473425
> schemaAdapter already brought up some performance implications and would be needed that schema validation happens once per partition at most, ideally once per executor/query From what I understand - The validation runs in PhysicalExprAdapterFactory::create(), which DataFusion calls once per Parquet file — not per batch or row. Please correct me if my understanding is wrong. also, i have fixed the merge conflict please re-trigger ci 🤞 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
