xudong963 commented on PR #20494: URL: https://github.com/apache/datafusion/pull/20494#issuecomment-4117370733
> I am a little worried about the complexity added in this patch for two reasons: Yes, the changes are in the hot path, for all cases, it'll do some checks. I encountered a similar overflow in the SPM path https://github.com/apache/datafusion/pull/20922, and introduced a different way to fix it: if we get the panic info, capture it, then progressively retry until no overflow, which only affects the overflow path. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
