tinfoil-knight commented on code in PR #11330:
URL: https://github.com/apache/datafusion/pull/11330#discussion_r1683249611
##########
datafusion/sql/src/utils.rs:
##########
@@ -263,6 +263,37 @@ pub(crate) fn normalize_ident(id: Ident) -> String {
}
}
+pub(crate) fn normalize_value(value: &Value) -> Result<String> {
Review Comment:
`utils` is generally for things that are used across multiple files
repeatedly.
Can we remove this function and perform the normalization in the `normalize`
method under the `ValueNormalizer` struct?
If we separate the string conversion and normalization (as suggested in
another comment), then we can move back the `value_to_string` fn too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
