coderfender commented on PR #21101: URL: https://github.com/apache/datafusion/pull/21101#issuecomment-4107028698
These are great numbers ! @neilconway . Could we perhaps also remove if conditions as well and see if those help out. Example : 1. Separate implementation for non null arrays ( to prevent if loop cycles inside the inner function) 2. Hot looping`ARROW_COMPUTE_THRESHOLD` if calls 3.min/max check (separate max vs min impl) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
