theirix commented on code in PR #20787:
URL: https://github.com/apache/datafusion/pull/20787#discussion_r2970394545
##########
datafusion/functions/src/strings.rs:
##########
@@ -75,6 +75,11 @@ impl StringArrayBuilder {
.extend_from_slice(array.value(i).as_bytes());
}
}
+ ColumnarValueRef::NullableBinaryArray(array) => {
Review Comment:
Thank you for the review, @kosiew !
It's a good spot for safety. I refactored the custom builders to enforce
checked behaviour when operations even involve binary arrays. Performing
validation in the `finish` method allows concatenating binary strings, which
could possibly be split in the middle of code points (see a special SLT case
for this). So it is performant and robust.
Also added SLTs for all code paths.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
