alamb commented on code in PR #21092:
URL: https://github.com/apache/datafusion/pull/21092#discussion_r2969946338
##########
datafusion/core/src/execution/context/mod.rs:
##########
@@ -1488,12 +1488,13 @@ impl SessionContext {
})?;
let state = self.state.read();
- let context = SimplifyContext::default()
+ let context = SimplifyContext::builder()
.with_schema(Arc::clone(prepared.plan.schema()))
Review Comment:
I recommend we also deprecate `SimplifyContext::with...` methods (can do it
as a follow on PR) and direct people to use the builder in their own code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]