martin-g commented on code in PR #1507:
URL:
https://github.com/apache/datafusion-ballista/pull/1507#discussion_r2936679121
##########
ballista/executor/src/config.rs:
##########
@@ -78,7 +78,7 @@ pub struct Config {
)]
pub concurrent_tasks: usize,
/// Task scheduling policy: pull-staged (executor polls) or push-staged
(scheduler pushes).
- #[arg(short = 's', long, default_value_t =
ballista_core::config::TaskSchedulingPolicy::PushStaged, help = "The task
scheduling policy for the scheduler, possible values: pull-staged, push-staged.
Default: push-staged")]
+ #[arg(short = 's', long, default_value_t =
ballista_core::config::TaskSchedulingPolicy::default(), help = "The task
scheduling policy for the scheduler, possible values: pull-staged, push-staged.
Default: push-staged")]
Review Comment:
```suggestion
#[arg(short = 's', long, default_value_t =
ballista_core::config::TaskSchedulingPolicy::default(), help = "The task
scheduling policy for the scheduler, possible values: pull-staged, push-staged.
)]
```
There is no need of this. It is given by Clap using the `default_value_t`:
```
-s, --task-scheduling-policy <TASK_SCHEDULING_POLICY>
The task scheduling policy for the scheduler, possible values:
pull-staged, push-staged. Default: push-staged
Possible values:
- pull-staged: Pull-based scheduling works in a similar way to
Apache Spark
- push-staged: push-based scheduling can result in lower latency
[default: push-staged] <---- HERE
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
