davidlghellin commented on PR #20487: URL: https://github.com/apache/datafusion/pull/20487#issuecomment-4060682211
Hi @n0r0shi, sorry I didn't notice your PR was already open — I submitted #20927 covering the same function. Happy to close mine. Feel free to grab any of my test cases if they're useful — I have 22 unit tests and 20 SLT tests covering Utf8View support, per-row NULL threshold behavior, negative thresholds, unicode, long strings, and case sensitivity. One edge case worth checking: in Spark JVM, a scalar NULL threshold returns NULL (planner constant folding), but a per-row NULL threshold in a column is treated as 0 and returns -1. The two paths behave differently by design. Great work on this! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
