askalt commented on code in PR #20900: URL: https://github.com/apache/datafusion/pull/20900#discussion_r2923885392
########## datafusion/physical-plan/src/execution_plan.rs: ########## @@ -1508,7 +1508,7 @@ pub fn reset_plan_states(plan: Arc<dyn ExecutionPlan>) -> Result<Arc<dyn Executi /// replace is requested. /// The size of `children` must be equal to the size of `ExecutionPlan::children()`. pub fn has_same_children_properties( - plan: &Arc<impl ExecutionPlan>, + plan: &impl ExecutionPlan, Review Comment: Yes, it is so. It looks ok to change this argument type as this API was not released yet. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
