buraksenn commented on code in PR #20846:
URL: https://github.com/apache/datafusion/pull/20846#discussion_r2913457380
##########
datafusion/physical-plan/src/union.rs:
##########
@@ -854,7 +853,7 @@ fn col_stats_union(
mut left: ColumnStatistics,
right: &ColumnStatistics,
) -> ColumnStatistics {
- left.distinct_count = Precision::Absent;
+ left.distinct_count =
left.distinct_count.add(&right.distinct_count).to_inexact();
Review Comment:
I've applied the formula. Thanks @jonathanc-n for review I was under the
assumption of we can simply add to have it as an upper bound value
##########
datafusion/physical-plan/src/union.rs:
##########
@@ -1043,6 +1043,62 @@ mod tests {
assert_eq!(result, expected);
}
+ #[tokio::test]
Review Comment:
thanks changed to simple test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
