alamb commented on code in PR #11495:
URL: https://github.com/apache/datafusion/pull/11495#discussion_r1680049275
##########
datafusion/sql/src/unparser/dialect.rs:
##########
@@ -45,6 +45,12 @@ pub trait Dialect {
fn interval_style(&self) -> IntervalStyle {
IntervalStyle::PostgresVerbose
}
+
+ // Does the dialect use DOUBLE PRECISION to represent Float64 rather than
DOUBLE?
+ // E.g. Postgres uses DOUBLE PRECISION instead of DOUBLE
+ fn use_double_precision_for_float64(&self) -> bool {
Review Comment:
Similarly to
https://github.com/apache/datafusion/pull/11494#discussion_r1680046876 what do
you think about making this simply return the AST type directly?
```suggestion
fn use_double_precision_for_float64(&self) -> sqlparser::ast::DataType {
```
That is likely a more flexible API -- this formulation seems very narrow for
postgres vs MySQL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
