neilconway commented on PR #20553: URL: https://github.com/apache/datafusion/pull/20553#issuecomment-3961338927
I think adding dependencies on `itoa` and `ryu` is justified, because the incremental speedup is significant (e.g., 1009 -> 614 us for int64/100). We could potentially use these crates elsewhere (e.g., `format_string`), but I'll worry about that later. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
